Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: alias detection for removed flags #71

Merged
merged 17 commits into from
Nov 13, 2023
Merged

fix: alias detection for removed flags #71

merged 17 commits into from
Nov 13, 2023

Conversation

jazanne
Copy link
Contributor

@jazanne jazanne commented Nov 2, 2023 •
edited
Loading

Fix issues where aliases that are removed are not included in comment

example:

CleanShot 2023-11-02 at 15 19 13

We do this by scanning the diff contents to see if any files that are part of a filepattern alias configuration contain aliases

Dependencies - wait for merge

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 2, 2023 •
edited
Loading

LaunchDarkly flag references

🔍 1 flag added or modified

Name Key Aliases found
Show: Live Tiles show-widgets newRandomAlias, show-widgets

❌ 1 flag removed

Name Key Aliases found
Beta UI beta-ui beta-ui, myRandomAlias

@github-actions github-actions bot added the ld-flags LaunchDarkly flags have been detected in the PR diff label Nov 2, 2023
@jazanne jazanne mentioned this pull request Nov 2, 2023
Merged
@jazanne jazanne added the hold label Nov 2, 2023
@jazanne jazanne changed the title test alias detection in diff fix: alias detection for removed flags Nov 2, 2023
@jazanne jazanne marked this pull request as ready for review November 2, 2023 19:29
@jazanne jazanne requested a review from a team November 2, 2023 19:29
@jazanne jazanne changed the base branch from main to jwhite/ref-builder November 3, 2023 20:10
@jazanne jazanne force-pushed the jwhite/alias-fix branch 2 times, most recently from bf1edc9 to fd43627 Compare November 3, 2023 20:24
Base automatically changed from jwhite/ref-builder to main November 3, 2023 20:42
@jazanne jazanne removed the hold label Nov 3, 2023
@jazanne jazanne merged commit 4730082 into main Nov 13, 2023
5 checks passed
@jazanne jazanne deleted the jwhite/alias-fix branch November 13, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karayusuf karayusuf karayusuf approved these changes

Assignees
No one assigned
Labels
ld-flags LaunchDarkly flags have been detected in the PR diff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jazanne @karayusuf